Messages in this thread | | | From | Pranith Kumar <> | Date | Wed, 20 Aug 2014 16:19:44 -0400 | Subject | Re: [PATCH v2] powerpc: booke_wdt: Fix build error as a module |
| |
On Wed, Aug 20, 2014 at 4:10 PM, Guenter Roeck <linux@roeck-us.net> wrote: > On Wed, Aug 20, 2014 at 03:26:46PM -0400, Pranith Kumar wrote: >> Building booke_wdt fails when trying to build as a module as there is no >> early_param() in module. Fix by using module_param() instead of early_param(). >> >> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> >> CC: Guenter Roeck <linux@roeck-us.net> > > Looks good as far as I can see. One question though: > >> +MODULE_ALIAS("booke_wdt"); > > Is this necessary ? If yes, shouldn't it be a separate patch to be applied > to -stable ?
Suppose this was actually built as a module. How do you pass the module parameters to this module? Only ways I know of are
./insmod booke_wdt booke_wdt_enabled=1 booke_wdt_period=3
or pass booke_wdt.booke_wdt_enabled=1 on the kernel boot params list.
So the alias is necessary to refer to this module to pass params.
About separate patch, I think it is only with conversion to module_param() that we need this alias.
Am I missing something?
-- Pranith
| |