lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "platform/x86/toshiba-apci.c possible bad if test?"
From
Date
On Wed, 20 Aug 2014 20:03:26 +0300, Ari Sundholm said:
> From: Ari Sundholm <ari@tuxera.com>
>
> This reverts commit bdc3ae7221213963f438faeaa69c8b4a2195f491.

> + if (sscanf(buf, "%i", &mode) != 1 && (mode != 2 || mode != 1))
> return -EINVAL;

I'm not convinced that's right either. If we come in and mode == 1, then
the mode != 2 is true, and yoinks...

I think this wanted to be sscanf() != 1 || ! (mode == 2 || mode == 1)

I'll spin a patch against the reverted version if desired.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-08-20 19:41    [W:0.931 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site