lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 002/104] crypto: af_alg - properly label AF_ALG socket
    Date
    From: Milan Broz <gmazyland@gmail.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 4c63f83c2c2e16a13ce274ee678e28246bd33645 upstream.

    Th AF_ALG socket was missing a security label (e.g. SELinux)
    which means that socket was in "unlabeled" state.

    This was recently demonstrated in the cryptsetup package
    (cryptsetup v1.6.5 and later.)
    See https://bugzilla.redhat.com/show_bug.cgi?id=1115120

    This patch clones the sock's label from the parent sock
    and resolves the issue (similar to AF_BLUETOOTH protocol family).

    Signed-off-by: Milan Broz <gmazyland@gmail.com>
    Acked-by: Paul Moore <paul@paul-moore.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    crypto/af_alg.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/crypto/af_alg.c b/crypto/af_alg.c
    index ac33d5f30778..bf948e134981 100644
    --- a/crypto/af_alg.c
    +++ b/crypto/af_alg.c
    @@ -21,6 +21,7 @@
    #include <linux/module.h>
    #include <linux/net.h>
    #include <linux/rwsem.h>
    +#include <linux/security.h>

    struct alg_type_list {
    const struct af_alg_type *type;
    @@ -243,6 +244,7 @@ int af_alg_accept(struct sock *sk, struct socket *newsock)

    sock_init_data(newsock, sk2);
    sock_graft(sk2, newsock);
    + security_sk_clone(sk, sk2);

    err = type->accept(ask->private, sk2);
    if (err) {
    --
    2.0.4


    \
     
     \ /
      Last update: 2014-08-20 14:21    [W:7.347 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site