Messages in this thread | | | Subject | Re: [PATCH v1 01/12] dmaengine: dw: move dw_dmac.h to where it belongs to | From | Andy Shevchenko <> | Date | Wed, 20 Aug 2014 12:28:20 +0300 |
| |
On Wed, 2014-08-20 at 14:25 +0530, Viresh Kumar wrote: > On Tue, Aug 19, 2014 at 10:59 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > There is a common storage for platform data related structures and definitions > > inside kernel source tree. The patch moves file from include/linux to > > include/linux/platform_data and renames it acoordingly. The users are also > > updated. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > > include/linux/dw_dmac.h | 111 ------------------------ > > include/linux/platform_data/dma-dw.h | 111 ++++++++++++++++++++++++ > > Nice work but wrong git commands to produce this patch.. > Always run format-patch with these options Atleast: > > git format-patch -C -M --thread=shallow > > With the -C -M option you would have got something like: > > include/linux/{dw_dmac.h => platform_data/dma-dw.h} | 0 > > Which would have made review so so easy :)
Thanks for reminding me this, though I thought I would do that way and *forgot* while rebasing series.
And thanks for Ack!
-- Andy Shevchenko <andriy.shevchenko@intel.com> Intel Finland Oy
-- Andy Shevchenko <andriy.shevchenko@intel.com> Intel Finland Oy
| |