Messages in this thread | | | Date | Wed, 20 Aug 2014 14:26:12 +0530 | Subject | Re: [PATCH v1 01/12] dmaengine: dw: move dw_dmac.h to where it belongs to | From | Viresh Kumar <> |
| |
On Wed, Aug 20, 2014 at 2:25 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On Tue, Aug 19, 2014 at 10:59 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: >> There is a common storage for platform data related structures and definitions >> inside kernel source tree. The patch moves file from include/linux to >> include/linux/platform_data and renames it acoordingly. The users are also >> updated. >> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> --- > >> include/linux/dw_dmac.h | 111 ------------------------ >> include/linux/platform_data/dma-dw.h | 111 ++++++++++++++++++++++++ > > Nice work but wrong git commands to produce this patch.. > Always run format-patch with these options Atleast: > > git format-patch -C -M --thread=shallow > > With the -C -M option you would have got something like: > > include/linux/{dw_dmac.h => platform_data/dma-dw.h} | 0 > > Which would have made review so so easy :)
Otherwise: Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
| |