lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Install udev rules in system-default directory
On (Tue) 19 Aug 2014 [19:20:20], Paolo Bonzini wrote:
> Il 07/08/2014 15:09, Amit Shah ha scritto:
> > +udevrules_DATA = 90-virtio-rng.rules
>
> If rng-tools is packaged with "make dist" you need this to be
>
> dist_udevrules_DATA = 90-virtio-rng.rules
>
> or alternatively
>
> EXTRA_DIST = 90-virtio-rng.rules
> udevrules_DATA = 90-virtio-rng.rules
>
> > +AC_ARG_WITH([udevrulesdir],
> > + AS_HELP_STRING([--with-udevrulesdir=DIR], [Directory for udev rules]),
> > + [],
> > + [with_udevrulesdir=$($PKG_CONFIG --variable=udevdir udev)"/rules.d"])
> > +AC_SUBST([udevrulesdir], [$with_udevrulesdir])
>
> You can use AM_CONDITIONAL to skip the installation if
> $with_udevrulesdir is "no" (aka --without-udevrulesdir). Then you'd have
>
> EXTRA_DIST = 90-virtio-rng.rules
> if INSTALL_UDEV_RULES
> udevrules_DATA = 90-virtio-rng.rules
> endif
>
> I don't know offhand if this works:
>
> if INSTALL_UDEV_RULES
> dist_udevrules_DATA = 90-virtio-rng.rules
> endif
>
> but I think so; you can check with "./configure --without-udevrulesdir
> && make && make dist".

Thanks! Will give this a shot for curiosity's sake. The
khwrngd-based patch has already been merged upstream, so this is now
obsolete.


Amit


\
 
 \ /
  Last update: 2014-08-20 07:21    [W:1.397 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site