lkml.org 
[lkml]   [2014]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000
Hi,

On Wed, Aug 20, 2014 at 12:46:33AM +0000, Chen, Alvin wrote:
>
> > Hi,
> >
> > On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote:
> > > From: Bryan O'Donoghue <bryan.odonoghue@intel.com>
> > >
> > > This patch is to enable the USB gadget device for Intel Quark X1000
> > >
> > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@intel.com>
> > > Signed-off-by: Bing Niu <bing.niu@intel.com>
> > > Signed-off-by: Alvin (Weike) Chen <alvin.chen@intel.com>
> >
> > Can someone confirm to me this is not another incarnation of chipidea ?
>
> No, this is not another incarnation of chipidea. And its cover letter is as following:
>
> On Mon, Aug 04, 2014 at 11:00:07AM -0700, Chen, Alvin wrote:
> > From: "Alvin (Weike) Chen" <alvin.chen@intel.com>
> >
> > Hi,
> > Intel Quark X1000 consists of one USB gadget device which can be PCI enumerated.
> > pch_udc layer doesn't support it. Thus, we add support for Intel Quark
> > X1000 USB gadget device as well.

hehe, right I *know* what the patch is doing. I can read the diff and
figure out that you're adding support for Quark to PCH UDC because
Quark's USB IP is the same, what I wasking was if that IP was actually
an instance of the chipidea UDC. After looking at the address space
definitions on both drivers, I see that it's not.

So tomorrow I'll look at this patch again.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-08-20 05:41    [W:0.061 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site