lkml.org 
[lkml]   [2014]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6] input: drv260x: Add TI drv260x haptics driver
Date
Dmitry

On 08/19/2014 03:24 PM, Dmitry Torokhov wrote:
> On Tue, Aug 19, 2014 at 08:13:32PM +0000, Murphy, Dan wrote:
>> On 08/19/2014 03:07 PM, Dmitry Torokhov wrote:
>>> On Tue, Aug 19, 2014 at 07:35:06PM +0000, Murphy, Dan wrote:
>>>> Dmitry
>>>>

<snip>

>>> ...
>>>
>>> That one I kept.
>>>
>>
>> Yes that is correct but the enable_gpio for non-dt enabled devices this enable_gpio
>> needs to come from the platform data structure. Without the enable gpio in the platform data
>> structure there is no way for non-dt enabled devices to set the gpio value.
>
> What else uses the platform data structure? You are accessing gpio by name, not
> by number, in the driver so I am not sure how non-dt case will use u32 defined
> in platform data.
>
>>
>> The haptics instance just stores the gpio descriptor returned from this call.
>
> Right.
>
>>
>> The devm_gpiod looks at the platform data is CONFIG_OF is not set.
>
> Umm, how? You do not pass it anywhere...

OK I drop my argument after drilling through gpio code.

Removal of this is OK.

Thanks

>
> Thanks.
>


--
------------------
Dan Murphy


\
 
 \ /
  Last update: 2014-08-19 23:21    [W:0.058 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site