Messages in this thread | | | Subject | Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed. | From | Philipp Zabel <> | Date | Tue, 19 Aug 2014 17:42:44 +0200 |
| |
Am Dienstag, den 19.08.2014, 18:26 +0300 schrieb Yannis Damigos: > This is a patch to the ipuv3-crtc.c file that fixes up two "lines > over 80 characters" warnings found by the checkpatch.pl tool, > keeping the alignment of the x/y/width/height parameters for > readability. > > Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> > --- > drivers/staging/imx-drm/ipuv3-crtc.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c > index 720868b..11e84a2 100644 > --- a/drivers/staging/imx-drm/ipuv3-crtc.c > +++ b/drivers/staging/imx-drm/ipuv3-crtc.c > @@ -201,7 +201,8 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc, > return ret; > } > > - return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb, > + return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, > + crtc->primary->fb, > 0, 0, mode->hdisplay, mode->vdisplay, > x, y, mode->hdisplay, mode->vdisplay); > } > @@ -226,9 +227,11 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id) > imx_drm_handle_vblank(ipu_crtc->imx_crtc); > > if (ipu_crtc->newfb) { > + struct ipu_plane *plane = ipu_crtc->plane[0]; > + > ipu_crtc->newfb = NULL; > - ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb, > - ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y); > + ipu_plane_set_base(plane, ipu_crtc->base.primary->fb, > + plane->x, plane->y); > ipu_crtc_handle_pageflip(ipu_crtc); > }
Yes, that does look better.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards Philipp
| |