Messages in this thread | | | Date | Mon, 18 Aug 2014 23:24:27 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH 1/2] KVM: fix cache stale memslot info with correct mmio generation number |
| |
Il 18/08/2014 23:15, David Matlack ha scritto: > I just realized how simple Paolo's idea is. I think it can be a one line > patch (without comments): > > [...] > update_memslots(slots, new, kvm->memslots->generation); > rcu_assign_pointer(kvm->memslots, slots); > synchronize_srcu_expedited(&kvm->srcu); > + slots->generation++; > > kvm_arch_memslots_updated(kvm); > [...]
Yeah, you're right. I think at this point it makes sense to put all generation handling in install_new_memslots, but with proper comments the above can do as well.
Would you like to send it? Patch 2 still applies on top.
| |