lkml.org 
[lkml]   [2014]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes
From
Date
On Mon, 2014-08-18 at 17:36 +0200, Krzysztof Majzerowicz-Jaszcz wrote:
> On 18/08/14 17:31, Joe Perches wrote:
> > On Mon, 2014-08-18 at 08:29 -0700, Alexander Duyck wrote:
> >> Doing any kind of pointer math on a void pointer is generally unsafe as
> >> it is an incomplete type. The only reason why it works in GCC is
> >> because GCC has a nonstandard extension that makes it report as having a
> >> size of 1.
> >
> > I know. It's used in quite a few places in kernel code
> > so I believe it's now a base assumption for the kernel.
> >
> Ok, so what do you suggest - void* or char* here ?

Do what you (or Alex) think is best.

My main point was trying to make the code a bit
clearer.



\
 
 \ /
  Last update: 2014-08-18 18:21    [W:0.048 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site