lkml.org 
[lkml]   [2014]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range()
Hello, Xishi, Tang.

On Mon, Aug 18, 2014 at 11:18:00AM +0800, Xishi Qiu wrote:
> If all the nodes are marked hotpluggable flag, alloc node data will fail.
> Because __next_mem_range_rev() will skip the hotpluggable memory regions.
> numa_register_memblks()
> setup_node_data()
> memblock_find_in_range_node()
> __memblock_find_range_top_down()
> for_each_mem_range_rev()
> __next_mem_range_rev()

I'm not sure clearing hotplug flag for all memory is the best approach
here. The problem is that there are places where we want to be
selectively ignoring the hotplug status and apparently we may want it
back later. Why not add an agument to memblock allocation / iteration
functions so that hotplug area can be skipped selectively?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2014-08-18 15:21    [W:0.527 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site