Messages in this thread | | | Date | Sun, 17 Aug 2014 10:11:30 -0700 | Subject | Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty. | From | Tim Kryger <> |
| |
On Fri, Aug 15, 2014 at 3:29 PM, Mark Brown <broonie@kernel.org> wrote: > On Fri, Aug 15, 2014 at 07:19:41AM -0700, Tim Kryger wrote: > >> That is a little different from my suggestion where the constraints >> check is skipped when the regulator output is fixed. It effectively >> does this now when the regulator itself provides the fixed voltage. >> However, the checks aren't skipped when that fixed voltage is coming >> from an ancestor. Why the difference? > > Nobody has written suitable code, and please bear in mind that even if > the code is written there will probably be cases where it's too > expensive for whatever reason so Javier's change is going to be needed.
I fail to see how replicating similar logic at all current regulator_list_voltage call sites would be any more efficient than handling this directly in regulator core.
| |