Messages in this thread | | | Date | Sun, 17 Aug 2014 07:08:21 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range() |
| |
Hello,
On Sat, Aug 16, 2014 at 10:36:41PM +0800, Xishi Qiu wrote: > numa_clear_node_hotplug()? There is only numa_clear_kernel_node_hotplug().
Yeah, that one.
> If we don't clear hotpluggable flag in free_low_memory_core_early(), the > memory which marked hotpluggable flag will not free to buddy allocator. > Because __next_mem_range() will skip them. > > free_low_memory_core_early > for_each_free_mem_range > for_each_mem_range > __next_mem_range
Ah, okay, so the patch fixes __next_mem_range() and thus makes free_low_memory_core_early() to skip hotpluggable regions unlike before. Please explain things like that in the changelog. Also, what's its relationship with numa_clear_kernel_node_hotplug()? Do we still need them? If so, what are the different roles that these two separate places serve?
Thanks.
-- tejun
| |