[lkml]   [2014]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 0/9] Add ACPI _DSD and unified device properties support
On Sat, Aug 16, 2014 at 09:53:50AM +0300, Mika Westerberg wrote:
> The recent publication of the ACPI 5.1 specification [1] adds a reserved name
> for Device Specific Data (_DSD, Section 6.2.5). This mechanism allows for
> passing arbitrary hardware description data to the OS. The exact format of the
> _DSD data is specific to the UUID paired with it [2].
> An ACPI Device Properties UUID has been defined [3] to provide a format
> compatible with existing device tree schemas. The purpose for this was to allow
> for the reuse of the existing schemas and encourage the development of firmware
> agnostic device drivers.
> This series accomplishes the following (as well as some other dependencies):
> * Add _DSD support to the ACPI core
> This simply reads the UUID and the accompanying Package
> * Add ACPI Device Properties _DSD format support
> This understands the hierarchical key:value pair structure
> defined by the Device Properties UUID
> * Add a unified device properties API with ACPI and OF backends
> This provides for the firmware agnostic device properties
> Interface to be used by drivers
> * Provides 2 example drivers that were previously Device Tree aware that
> can now be used with either Device Tree or ACPI Device Properties. The
> both drivers use an arbitrary _HID.
> This has been tested on Minnowboard with relevant parts of the modified
> DSDT at the end of this email.
> This series does not provide for a means to append to a system DSDT. That
> will ultimately be required to make the most effective use of the _DSD
> mechanism. Work is underway on that as a separate effort.
> [1]
> [2]
> [3]
> Aaron Lu (3):
> of: Add property_ops callback for devices with of_node
> gpiolib: add API to get gpio desc and flags
> Input: gpio_keys_polled - Make use of device property API
> Max Eliaser (1):
> leds: leds-gpio: Make use of device property API
> Mika Westerberg (4):
> ACPI: Add support for device specific properties
> ACPI: Document ACPI device specific properties
> mfd: Add ACPI support
> gpio: sch: Consolidate core and resume banks
> Rafael J. Wysocki (1):
> Driver core: Unified device properties interface for platform firmware

One issue I noticed with the series: the new read functions, when given
an integer type, don't appear to do any range-checking to make sure the
returned value falls within the range of that type. They should do so,
and return -EOVERFLOW if so. And the documentation of the new functions
should note that explicitly as an error case.

With that fixed:
Reviewed-by: Josh Triplett <>

 \ /
  Last update: 2014-08-16 21:01    [W:0.021 / U:30.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site