Messages in this thread | | | Date | Sat, 16 Aug 2014 20:33:25 +0300 | From | Dan Aloni <> | Subject | Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips |
| |
On Thu, Aug 14, 2014 at 05:22:18PM +0300, Yaniv Gardi wrote: > diff --git a/drivers/scsi/ufs/ufs-msm.h b/drivers/scsi/ufs/ufs-msm.h > new file mode 100644 > index 0000000..6e93f1e > --- /dev/null > +++ b/drivers/scsi/ufs/ufs-msm.h > @@ -0,0 +1,158 @@ [...] > +}; > + > +static LIST_HEAD(phy_list); > +
Just noticed this via a quick glance - Seems that this variable is not referenced by any of the compilation units, what's the purpose of it? And as a static global in a shared private, each of the including compilation units gets a copy, which I am not sure was intended anyway.
-- Dan Aloni
| |