lkml.org 
[lkml]   [2014]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] regulator: Add stub for devm_regulator_get_exclusive
From
2014-08-13 5:55 GMT+08:00 Mark Brown <broonie@kernel.org>:
> On Tue, Aug 12, 2014 at 09:37:09AM +0800, Axel Lin wrote:
>> Fix below build error when !CONFIG_REGULATOR.
>>
>> CC drivers/gpu/drm/msm/hdmi/hdmi.o
>> drivers/gpu/drm/msm/hdmi/hdmi.c: In function 'hdmi_init':
>> drivers/gpu/drm/msm/hdmi/hdmi.c:126:3: error: implicit declaration of function 'devm_regulator_get_exclusive' [-Werror=implicit-function-declaration]
>
> So, I just looked at that driver - it errors out on probe without the
> regualtor. Are you sure the fix isn't to add a dependency on the
> regulator API or convert it back to using normal regulator gets (it was
> converted without comment as part of a DT conversion), or indeed to
> using the bulk regulator API. It looks awfully like the driver is just
> open coding devm_regulator_bulk_get() and friends.
>
> There is no explanation at all in either the changelog or the code for
> why the driver is asking for exclusive regulators.
Hi Rob,
Any feedback about Mark's comment?

Hi Mark,
Even though not for this build fix, I think the patch is still good.
Should I remove the build error message and resend the patch to you?

Regards,
Axel


\
 
 \ /
  Last update: 2014-08-16 15:41    [W:0.033 / U:4.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site