lkml.org 
[lkml]   [2014]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] x86, MCE: eliminate the strange combination of return and break
Date
What do you feel when you see the code snippet like that shown below?

switch (c) {
case X:
... ...
return 1;
break;
case Y:
... ...
return 1;
break;
}

All in all, in many ways I'm not feeling well. I think a small change
is needed here. This patch aims to eliminate the strange combination of
*return* and *break* in the above switch-statement.

Signed-off-by: Chen Yucong <slaoub@gmail.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index bd9ccda..5915be5 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1618,15 +1618,15 @@ static int __mcheck_cpu_ancient_init(struct cpuinfo_x86 *c)
switch (c->x86_vendor) {
case X86_VENDOR_INTEL:
intel_p5_mcheck_init(c);
- return 1;
break;
case X86_VENDOR_CENTAUR:
winchip_mcheck_init(c);
- return 1;
break;
+ default:
+ return 0;
}

- return 0;
+ return 1;
}

static void __mcheck_cpu_init_vendor(struct cpuinfo_x86 *c)
--
1.7.10.4


\
 
 \ /
  Last update: 2014-08-16 15:41    [W:0.023 / U:3.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site