lkml.org 
[lkml]   [2014]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] isdn/gigaset: use USB API functions rather than constants
Am 15.08.2014 um 18:24 schrieb Himangi Saraogi:
> This patch introduces the use of the function usb_endpoint_num.
>
> The Coccinelle semantic patch that makes these changes is as follows:
>
> @@ struct usb_endpoint_descriptor *epd; @@
>
> - (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\))
> + usb_endpoint_num(epd)
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Tilman Schmidt <tilman@imap.cc>

Nice.
Are you planning a similar patch for bas-gigaset.c too?
Otherwise I'll prepare one myself.

Thanks,
Tilman


> ---
> drivers/isdn/gigaset/usb-gigaset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index d0a41cb..00d4077 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -751,7 +751,7 @@ static int gigaset_probe(struct usb_interface *interface,
> /* Fill the interrupt urb and send it to the core */
> usb_fill_int_urb(ucs->read_urb, udev,
> usb_rcvintpipe(udev,
> - endpoint->bEndpointAddress & 0x0f),
> + usb_endpoint_num(endpoint)),
> ucs->rcvbuf, buffer_size,
> gigaset_read_int_callback,
> cs, endpoint->bInterval);
>

--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-08-16 13:01    [W:0.030 / U:3.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site