lkml.org 
[lkml]   [2014]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] ipmi/of: Don't use unavailable interfaces
On 08/14/2014 01:39 AM, Benjamin Herrenschmidt wrote:
> If an IPMI controller is used by the firmware and as such marked with
> a reserved status, we shouldn't use it.

I've added this to my IPMI tree. I can't comment on it's correctness,
others would know better than me, but it seems reasonable.

Thanks,

-corey

> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Not tested, found by inspection as we are investigating how to plumb
> IPMI on one of our future platforms. Our FW uses the device-tree for
> its own internal use and tags stuff that it reserves for itself using
> the "status" property. This is likely to be the case of our BT interface.
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 5d66568..4fc8931 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2658,6 +2658,9 @@ static int ipmi_probe(struct platform_device *dev)
> if (!match)
> return -EINVAL;
>
> + if (!of_device_is_available(np))
> + return -EINVAL;
> +
> ret = of_address_to_resource(np, 0, &resource);
> if (ret) {
> dev_warn(&dev->dev, PFX "invalid address from OF\n");
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



\
 
 \ /
  Last update: 2014-08-17 02:41    [W:0.023 / U:10.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site