Messages in this thread | | | Date | Fri, 15 Aug 2014 10:23:10 +0200 | From | Michal Hocko <> | Subject | Re: [Patch v3 2/2] freezer: remove obsolete comments in __thaw_task() |
| |
On Thu 14-08-14 14:15:26, Cong Wang wrote: > __thaw_task() no longer clears frozen flag.
since a3201227f803 (freezer: make freezing() test freeze conditions in effect instead of TIF_FREEZE).
> Cc: David Rientjes <rientjes@google.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Tejun Heo <tj@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Michal Hocko <mhocko@suse.cz> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
> --- > kernel/freezer.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/kernel/freezer.c b/kernel/freezer.c > index 5b25351..33cbcb0 100644 > --- a/kernel/freezer.c > +++ b/kernel/freezer.c > @@ -156,12 +156,6 @@ void __thaw_task(struct task_struct *p) > { > unsigned long flags; > > - /* > - * Clear freezing and kick @p if FROZEN. Clearing is guaranteed to > - * be visible to @p as waking up implies wmb. Waking up inside > - * freezer_lock also prevents wakeups from leaking outside > - * refrigerator. > - */ > spin_lock_irqsave(&freezer_lock, flags); > if (frozen(p)) > wake_up_process(p); > -- > 1.8.3.1 >
-- Michal Hocko SUSE Labs
| |