Messages in this thread | | | From | Andy Lutomirski <> | Date | Thu, 14 Aug 2014 10:34:56 -0700 | Subject | Re: [PATCH v6 2/7] random, timekeeping: Collect timekeeping entropy in the timekeeping code |
| |
On Wed, Aug 13, 2014 at 10:43 PM, Andy Lutomirski <luto@amacapital.net> wrote: > Currently, init_std_data calls ktime_get_real(). This imposes > awkward constraints on when init_std_data can be called, and > init_std_data is unlikely to collect the full unpredictable data > available to the timekeeping code, especially after resume. > > Remove this code from random.c and add the appropriate > add_device_randomness calls to timekeeping.c instead.
*sigh* this is buggy:
> + add_device_randomness(tk, sizeof(tk));
sizeof(*tk)
> + add_device_randomness(tk, sizeof(tk));
ditto.
I'll fix this for v7, but I'll wait awhile for other comments to reduce spam.
--Andy
| |