lkml.org 
[lkml]   [2014]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf ui/tui: Fix a small callchain display bug

* Namhyung Kim <namhyung@kernel.org> wrote:

> The currently when perf TUI report shows callchain, the first level
> chains have bogus '+' sign even though only the last one has children.
>
> Since they are on a single line of the chain, toggling intermediate
> entries has no effect. Fix it to show '+' sign at the last entry
> only. Note that non-first level callchain entries don't have this
> problem.
>
> Before:
>
> Children Self Command Shared Object Symbols
> ---------------------------------------------------------------------------
> - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter
> + cpuidle_wrap_enter
> + cpuidle_enter_tk
> + cpuidle_idle_call
> + cpu_idle
>
> After:
>
> Children Self Command Shared Object Symbols
> ---------------------------------------------------------------------------
> - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter
> cpuidle_wrap_enter
> cpuidle_enter_tk
> cpuidle_idle_call
> + cpu_idle
>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Nice fix!

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-08-13 10:41    [W:0.065 / U:1.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site