Messages in this thread | | | Date | Wed, 13 Aug 2014 10:19:09 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf ui/tui: Fix a small callchain display bug |
| |
* Namhyung Kim <namhyung@kernel.org> wrote:
> The currently when perf TUI report shows callchain, the first level > chains have bogus '+' sign even though only the last one has children. > > Since they are on a single line of the chain, toggling intermediate > entries has no effect. Fix it to show '+' sign at the last entry > only. Note that non-first level callchain entries don't have this > problem. > > Before: > > Children Self Command Shared Object Symbols > --------------------------------------------------------------------------- > - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter > + cpuidle_wrap_enter > + cpuidle_enter_tk > + cpuidle_idle_call > + cpu_idle > > After: > > Children Self Command Shared Object Symbols > --------------------------------------------------------------------------- > - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter > cpuidle_wrap_enter > cpuidle_enter_tk > cpuidle_idle_call > + cpu_idle > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Nice fix!
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
| |