Messages in this thread | | | From | "Sharma, Sanjeev" <> | Subject | RE: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert_held() | Date | Tue, 12 Aug 2014 06:28:39 +0000 |
| |
Done !
Thanks Sanjeev Sharma
-----Original Message----- From: Greg KH [mailto:gregkh@linuxfoundation.org] Sent: Tuesday, August 12, 2014 11:32 AM To: Sharma, Sanjeev Cc: hdegoede@redhat.com; kraxel@redhat.com; mdharm-usb@one-eyed-alien.net; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org Subject: Re: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert_held()
On Tue, Aug 12, 2014 at 11:38:37AM +0530, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration and > therefore it would be advise to replace with lockdep_assert_held().
Add "on some architectures" in here somewhere, as it's not broken on the large majority of UP cpus :)
thanks,
greg k-h
| |