lkml.org 
[lkml]   [2014]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.
On Fri, Aug 08, 2014 at 12:05:38PM +0300, Dan Carpenter wrote:
> On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote:
> > This patch clear some code that was not doing any help.
> > Pointed out by Larry.Finger
> >
>
> The patch is fine but the changelog doesn't inpsire confidence. It
> should say:
>
> This patch removes some unneeded code.
> 1) kzalloc() allocates 4 extra bytes so that we can align the return
> value. But actually the return value is already aligned so we can
> remove the + 4 and the call to N_BYTE_ALIGMENT().
> 2) The memset() isn't needed because kzalloc() zeroes the allocation.
>
> Suggested-by: Larry Finger <Larry.Finger@lwfinger.net>

Adrian, can you please fix this up and resend the series based on Dan's
comments?

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-08-10 14:21    [W:1.189 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site