Messages in this thread | | | Date | Wed, 9 Jul 2014 17:42:02 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH char-misc-next v2 2/8] misc: mic: add a bus driver for virtual MIC devices |
| |
On Thu, May 29, 2014 at 02:23:59PM -0700, Sudeep Dutt wrote: > +/** > + * mbus_device - representation of a device using mbus > + * @priv: private pointer for the driver's use. > + * @mmio_va: virtual address of mmio space > + * @hw_ops: the hardware ops supported by this device. > + * @id: the device type identification (used to match it with a driver). > + * @dev: underlying device. > + * be used to communicate with. > + * @index: unique position on the mbus bus > + */ > +struct mbus_device { > + void *priv;
What's wrong with the built-in "private" pointer that struct device has? That is why it is there...
> + void __iomem *mmio_va; > + struct mbus_hw_ops *hw_ops; > + struct mbus_device_id id; > + struct device dev; > + int index; > +};
| |