lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version
    Date


    > -----Original Message-----
    > From: Christoph Hellwig [mailto:hch@infradead.org]
    > Sent: Wednesday, July 9, 2014 1:42 AM
    > To: KY Srinivasan
    > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
    > ohering@suse.com; jbottomley@parallels.com; jasowang@redhat.com;
    > apw@canonical.com; linux-scsi@vger.kernel.org; stable@vger.kernel.org
    > Subject: Re: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS
    > protocol version
    >
    > > + if ((vmbus_proto_version == VERSION_WS2008) ||
    > > + (vmbus_proto_version == VERSION_WIN7)) {
    >
    > This has superflous braces and doesn't use proper Linux indentation.
    >
    > But I think simply using a switch here might be cleaner anyway.
    I will do as you have suggested.

    K. Y


    \
     
     \ /
      Last update: 2014-07-09 22:41    [W:4.041 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site