lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to hci.h
On 07/09/2014 11:26 AM, Dan Carpenter wrote:
>> /* GetInformation mac address */
>> len = 0;
>> @@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device *dev)
>> hci->length = H2B(len);
>> gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len);
>>
>> - val = (1<<BIT_WIMAX) | (1<<BIT_MULTI_CS);
>> + val = (1 << T_CAPABILITY_WIMAX) | (1 << T_CAPABILITY_MULTI_CS);
>
> Double shifting here... It should just be:
>
> val = T_CAPABILITY_WIMAX | T_CAPABILITY_MULTI_CS;
>

Ooops! Thanks for spotting that, will submit a corrected patch.

M.


\
 
 \ /
  Last update: 2014-07-09 21:21    [W:0.195 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site