lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectcheckpatch minor issue
Hi,

In one of my posted patch David spotted an indentation error, I thought
these trivial mistakes are catched by checkpatch. Maybe it shouldn't,
but otherwise you should check this issue, see it in the mail below.

Regards,

Zoli

-------- Original Message --------
Subject: Re: [PATCH net-next 1/3 v4] pktgen: Fill the payload optionally
with a pattern
Date: Tue, 8 Jul 2014 11:28:38 -0700
From: David Miller <davem@davemloft.net>
To: <zoltan.kiss@citrix.com>
CC: <steffen.klassert@secunet.com>, <minipli@googlemail.com>,
<dborkman@redhat.com>, <tgraf@suug.ch>, <joe@perches.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xenproject.org>

From: Zoltan Kiss <zoltan.kiss@citrix.com>
Date: Wed, 2 Jul 2014 20:54:13 +0100

> @@ -1129,11 +1133,13 @@ static ssize_t pktgen_if_write(struct file *file,
> i += len;
>
> if (node_possible(value)) {
> + int j;
> pkt_dev->node = value;
> sprintf(pg_result, "OK: node=%d", pkt_dev->node);
> - if (pkt_dev->page) {
> - put_page(pkt_dev->page);
> - pkt_dev->page = NULL;
> + for (j = 0; j < MAX_SKB_FRAGS; ++j)
> + if (pkt_dev->pages[j]) {
> + put_page(pkt_dev->pages[j]);
> + pkt_dev->pages[j] = NULL;
> }
> }

I'm scratching my head with the bracing created here, and it's because
the indentation is wrong:

for () /* <-- no openning curly brace */
if () {
x;
y;
} /* <-- thus, wrong indentation */

Please resubmit this series with this fixed and #3 adjusted as per the
feedback you've received.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html




\
 
 \ /
  Last update: 2014-07-09 17:41    [W:0.059 / U:9.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site