Messages in this thread | | | Date | Wed, 9 Jul 2014 12:12:15 +0200 | From | Olaf Hering <> | Subject | Re: [Xen-devel] [PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors |
| |
On Wed, Jul 09, Vitaly Kuznetsov wrote:
> > Also I am wondering why it was not done as part of copy_oldmem_page() > > so that respective arch could hide all the details. > Afaiac that wouldn't solve the mmap issue I'm trying to address but we > can ask Olaf why he preferred pfn_is_ram() path.
Every copy_oldmem_page would need to know about the pfn_is_ram function, so I think its better to keep that part of the code private to fs/proc/vmcore.c
Perhaps pfn_is_ram could be named pfn_is_backed_by_ram, but the comments make it clear what the function does.
Olaf
| |