lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] staging: silicom: checkpatch fixes
The patch does too many things, break it up into one type of fix per
patch.

On Tue, Jul 01, 2014 at 02:24:36PM +0200, Davide Gianforte wrote:
> Chechpatch.pl cleanup
>
> There are still some warnings, most of them are lines over 80 chars
> (mainly a semicolon or closing parenthesis).
>
> Where not specified, I defaulted printk with no log level into pr_debug

No. You can't just use pr_debug for everything. Also some of them are
not whole line prints so the pr_debug() will put extra info in the
middle of the lines.

Write a hello_world.ko kernel module and play with the printk until you
understand what I mean.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-07-09 12:21    [W:0.063 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site