lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 1/2] perf ignore LBR and extra_regs.
On Wed, Jul 09, 2014 at 02:32:28PM +0000, Liang, Kan wrote:
>
>
> > On Tue, Jul 08, 2014 at 09:49:40AM -0700, kan.liang@intel.com wrote:
> > > +/*
> > > + * Under certain circumstances, access certain MSR may cause #GP.
> > > + * The function tests if the input MSR can be safely accessed.
> > > + */
> > > +static inline bool check_msr(unsigned long msr) {
> > > + u64 value;
> > > +
> > > + if (rdmsrl_safe(msr, &value) < 0)
> > > + return false;
> > > + if (wrmsrl_safe(msr, value) < 0)
> > > + return false;
> > > + return true;
> > > +}
> >
> > What does this thing return after patch 2? does the write still fault or will
> > KVM silently take writes too?
>
> If applying patch 2, the function will return true. The KVM just simply ignore the reads/writes.

OK, then that's broken too. We want a function to return false for any
malfunctioning MSR, ignoring writes and returning 0s is not proper
functioning.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-07-12 11:21    [W:0.061 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site