Messages in this thread | | | Date | Tue, 08 Jul 2014 14:17:08 -0700 (PDT) | Subject | Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks | From | David Miller <> |
| |
From: David Decotigny <decot@googlers.com> Date: Tue, 8 Jul 2014 12:35:14 -0700
> Thanks for the feedback. This patch results from manual inspection of > the code. I agree my commit description is abusive: in the case of > bonding, I think everything is fine, there should be no ref leak, > cleanup paths seem clean. > > My point was to make things more predictable: ndo_netpoll_cleanup > called anyways to acknowledge actual loss of a ref to npinfo, > irrespective of whether it's the last ref or not. Without this patch, > calling ndo_netpoll_cleanup would depend on some timing behavior, hard > to predict, and users of the API have better be careful to reclaim the > refs manually anyways: as a consequence, not sure this callback is > actually required in its current inception.
You've increased my confusion rather than decreased it.
You fail to address the core issue in my feedback:
Whoever drops the refcount to zero must be the one to invoke the cleanup function.
Please address this concisely, and directly.
| |