lkml.org 
[lkml]   [2014]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 024/125] USB: sierra: fix AA deadlock in open error path
    3.2.61-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <jhovold@gmail.com>

    commit 353fe198602e8b4d1c7bdcceb8e60955087201b1 upstream.

    Fix AA deadlock in open error path that would call close() and try to
    grab the already held disc_mutex.

    Fixes: b9a44bc19f48 ("sierra: driver urb handling improvements")

    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/sierra.c | 21 +++++++++++++--------
    1 file changed, 13 insertions(+), 8 deletions(-)

    --- a/drivers/usb/serial/sierra.c
    +++ b/drivers/usb/serial/sierra.c
    @@ -868,14 +868,9 @@ static int sierra_open(struct tty_struct
    usb_sndbulkpipe(serial->dev, endpoint) | USB_DIR_IN);

    err = sierra_submit_rx_urbs(port, GFP_KERNEL);
    - if (err) {
    - /* get rid of everything as in close */
    - sierra_close(port);
    - /* restore balance for autopm */
    - if (!serial->disconnected)
    - usb_autopm_put_interface(serial->interface);
    - return err;
    - }
    + if (err)
    + goto err_submit;
    +
    sierra_send_setup(port);

    serial->interface->needs_remote_wakeup = 1;
    @@ -885,6 +880,16 @@ static int sierra_open(struct tty_struct
    usb_autopm_put_interface(serial->interface);

    return 0;
    +
    +err_submit:
    + sierra_stop_rx_urbs(port);
    +
    + for (i = 0; i < portdata->num_in_urbs; i++) {
    + sierra_release_urb(portdata->in_urbs[i]);
    + portdata->in_urbs[i] = NULL;
    + }
    +
    + return err;
    }




    \
     
     \ /
      Last update: 2014-07-08 22:42    [W:4.147 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site