Messages in this thread | | | Date | Mon, 07 Jul 2014 18:12:23 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 2/7] arm64: Support restart through restart notifier call chain |
| |
On 07/07/2014 02:16 PM, Andrew Morton wrote: > On Sun, 6 Jul 2014 16:38:15 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > >> The kernel core now supports a notifier call chain to restart >> the system. Call it if arm_pm_restart is not set. >> >> ... >> >> --- a/arch/arm64/kernel/process.c >> +++ b/arch/arm64/kernel/process.c >> @@ -174,6 +174,9 @@ void machine_restart(char *cmd) >> /* Now call the architecture specific reboot code. */ >> if (arm_pm_restart) >> arm_pm_restart(reboot_mode, cmd); >> + else >> + blocking_notifier_call_chain(&restart_notifier_list, >> + reboot_mode, cmd); > > It would be a bit neater to have a helper function to perform the call, > rather than directly accessing the notifier list. Apart from anything > else, this hides the fact that the core code (presently!) uses the > blocking_ style notifiers. >
Introduced kernel_restart_notify (proposals for better names welcome). As a side effect, moved restart_notifier_list into kernel/reboot.c and made it static.
Thanks, Guenter
| |