Messages in this thread | | | Date | Mon, 7 Jul 2014 22:00:05 +0200 | Subject | Re: [PATCH] video: backlight: jornada720_lcd.c: Cleaning up variable that is never used | From | Rickard Strandqvist <> |
| |
2014-07-07 12:46 GMT+02:00 Lee Jones <lee.jones@linaro.org>: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> >> --- >> drivers/video/backlight/jornada720_lcd.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > Solve it the other way around. > > Add a check and return the value if an error is returned.
Hi
Ok, I take the opportunity to make a bigger change to clarify the similarities in function. Hope you like it, otherwise I can make the minor change instead.
Kind regards Rickard Strandqvist
| |