Messages in this thread | | | Date | Mon, 07 Jul 2014 17:21:33 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH] staging: iio: Introduce the use of devm_ioremap_resource |
| |
On 07/07/14 13:36, Lars-Peter Clausen wrote: > On 07/07/2014 02:36 PM, Jonathan Cameron wrote: >> On 01/07/14 19:44, Himangi Saraogi wrote: >>> This patch introduces the use of devm_ioremap_resource. It does away >>> with call to request_mem_region and the error checking on >>> platform_get_resource. Also, the calls to free the allocated resources >>> like release_mem_region and iounmap are done away with. The ret variable >>> in the probe function is also eliminated. Also, a bug is fixed as the >>> goto in the error handling of request_mem_region should not have >>> called release_mem_region which releases a resource that has not been >>> allocated. >>> >>> Signed-off-by: Himangi Saraogi <himangi774@gmail.com> >>> Acked-by: Julia Lawall <julia.lawall@lip6.fr> >> Again, looks superficially fine, but I'd like an ack from someone >> at Analog ideally. >> Cc'd Lars > > Acked-by: Lars-Peter Clausen <lars@metafoo.de> Applied to the togreg branch of iio.git. This will be initially pushed out as testing for the autobuilders to play.
Thanks,
Jonathan
| |