Messages in this thread | | | Date | Mon, 7 Jul 2014 15:50:16 +0100 | From | Matt Fleming <> | Subject | Re: [PATCH v7 01/10] arch/ia64: Define early_memunmap() |
| |
On Mon, 30 Jun, at 07:52:55PM, Daniel Kiper wrote: > This is odd to use early_iounmap() function do tear down mapping > created by early_memremap() function, even if it works right now, > because they belong to different set of functions. The former is > I/O related function and the later is memory related. So, create > early_memunmap() macro which in real is early_iounmap(). This > thing will help to not confuse code readers longer by mixing > functions from different classes. > > EFI patches following this patch uses that functionality. > > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com> > --- > arch/ia64/include/asm/io.h | 1 + > 1 file changed, 1 insertion(+)
Tony, this looks pretty straight forward but I'd be much obliged if you could give me an Acked-by.
-- Matt Fleming, Intel Open Source Technology Center
| |