lkml.org 
[lkml]   [2014]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] thunderbolt: Correct the size argument to devm_kzalloc
From
Date
On Sun, 2014-07-06 at 21:43 +0530, Himangi Saraogi wrote:
> nhi->rx_rings does not have type as struct tb_ring *, as it is a
> double pointer so the elements of the array should have pointer type,
> not structure type.
[]
> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
[]
> @@ -570,10 +570,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work);
>
> nhi->tx_rings = devm_kzalloc(&pdev->dev,
> - nhi->hop_count * sizeof(struct tb_ring),
> + nhi->hop_count * sizeof(*nhi->tx_rings),
> GFP_KERNEL);
> nhi->rx_rings = devm_kzalloc(&pdev->dev,
> - nhi->hop_count * sizeof(struct tb_ring),
> + nhi->hop_count * sizeof(*nhi->rx_rings),
> GFP_KERNEL);

It could use devm_kcalloc here too.

btw: are there many false positives with the cocci test?



\
 
 \ /
  Last update: 2014-07-06 19:01    [W:0.069 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site