lkml.org 
[lkml]   [2014]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement
On Fri, 4 Jul 2014 22:59:41 +0200
Julian Andres Klode <jak@jak-linux.org> wrote:

> On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote:
> > Hi,
> >
> > This patch fixes the following warning reported by checkpatch.pl:
> >
> > WARNING: else is not generally useful after a break or return
> > #235: FILE: drivers/staging/nvec/nvec.c:235:
> >
> > Regards
> > Pawel Lebioda
> >
> > Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> > drivers/staging/nvec/nvec.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Hi Pawel,
>
> Please format your patches correctly. There should be no
> "Hi", no "Regards", etc. After the signed off should be a
> dashed line.
>
> Use git format-patch to format patches and you can send
> them using git-send-email.

yes, this way you reduce some apply-burdon from Greg. Ideally,
you would combine all patches (one patch per checkpatch warning)
in a common thread like this:

git-format-patch --cover-letter --thread -s <first commit of your
patches>

This way you could add some comments (if any) to the cover letter
and just keep the plain checkpatch message in the other patches. This
has also the advantage that the maintainers only have to ack the "cover
letter".

Marc

--
Marc Dietrich <marvin24@gmx.de>


\
 
 \ /
  Last update: 2014-07-05 14:21    [W:0.052 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site