Messages in this thread Patch in this message | | | Date | Sat, 5 Jul 2014 03:41:52 -0700 | From | tip-bot for Rickard Strandqvist <> | Subject | [tip:perf/core] tools lib traceevent: Fix a risk for doing free on uninitialized pointer |
| |
Commit-ID: 21da83fb6c3ff67e969b8770bbb33138c9ede88e Gitweb: http://git.kernel.org/tip/21da83fb6c3ff67e969b8770bbb33138c9ede88e Author: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> AuthorDate: Tue, 24 Jun 2014 13:09:10 +0200 Committer: Jiri Olsa <jolsa@kernel.org> CommitDate: Fri, 27 Jun 2014 11:14:47 +0200
tools lib traceevent: Fix a risk for doing free on uninitialized pointer
Fix a risk of doing free on an uninitialized pointer.
This was found using a static code analysis program called cppcheck.
Acked-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Link: http://lkml.kernel.org/r/1403608150-13037-1-git-send-email-rickard_strandqvist@spectrumdigital.se Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/lib/traceevent/event-parse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 93825a1..cf3a44b 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -2395,7 +2395,7 @@ process_flags(struct event_format *event, struct print_arg *arg, char **tok) { struct print_arg *field; enum event_type type; - char *token; + char *token = NULL; memset(arg, 0, sizeof(*arg)); arg->type = PRINT_FLAGS; @@ -2448,7 +2448,7 @@ process_symbols(struct event_format *event, struct print_arg *arg, char **tok) { struct print_arg *field; enum event_type type; - char *token; + char *token = NULL; memset(arg, 0, sizeof(*arg)); arg->type = PRINT_SYMBOL; @@ -2487,7 +2487,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok) { struct print_arg *field; enum event_type type; - char *token; + char *token = NULL; memset(arg, 0, sizeof(*arg)); arg->type = PRINT_HEX;
| |