Messages in this thread | | | Date | Sat, 5 Jul 2014 00:01:20 -0400 | Subject | Re: [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe | From | Nick Krause <> |
| |
I didn't compile check it seems to be a valid line after reading this. I will resend a new patch removing the FIX ME line. Sorry Nick
On Fri, Jul 4, 2014 at 11:58 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2014-07-04 at 23:20 -0400, Nicholas Krause wrote: >> This removes the sizeof(frame) from the call to get_sigframe on line >> 243 in order to fix the call to this function as the sizeof in not >> needed to call this function. > > How did you compile this? > > arch/parisc/kernel/signal.c:178:get_sigframe(struct k_sigaction *ka, unsigned long sp, size_t frame_size) > >> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c > [] >> @@ -240,8 +240,7 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, > [] >> - /*FIXME: frame_size parameter is unused, remove it. */ >> - frame = get_sigframe(ka, usp, sizeof(*frame)); >> + frame = get_sigframe(ka, usp) > > Nichola >
| |