Messages in this thread | | | Date | Sat, 5 Jul 2014 00:55:58 +0200 | Subject | Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void | From | Linus Walleij <> |
| |
On Sun, Jun 8, 2014 at 2:12 PM, Alexandre Courbot <gnurou@gmail.com> wrote: > On Thu, Jun 5, 2014 at 3:22 AM, abdoulaye berthe <berthe.ab@gmail.com> wrote:
>> This avoids handling gpiochip remove error in device >> remove handler. >> (...) >> Signed-off-by: abdoulaye berthe <berthe.ab@gmail.com> >> - list_del(&chip->list); >> + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) >> + panic("gpio: removing gpiochip with gpios still requested\n"); > > Really, really I don't think we should panic here.
Nope dev_crit() is the right thing, with a big fat warning message.
Yours, Linus Walleij
| |