lkml.org 
[lkml]   [2014]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void
From
On Sun, Jun 8, 2014 at 2:12 PM, Alexandre Courbot <gnurou@gmail.com> wrote:
> On Thu, Jun 5, 2014 at 3:22 AM, abdoulaye berthe <berthe.ab@gmail.com> wrote:

>> This avoids handling gpiochip remove error in device
>> remove handler.
>>
(...)
>> Signed-off-by: abdoulaye berthe <berthe.ab@gmail.com>
>> - list_del(&chip->list);
>> + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
>> + panic("gpio: removing gpiochip with gpios still requested\n");
>
> Really, really I don't think we should panic here.

Nope dev_crit() is the right thing, with a big fat warning message.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-07-05 02:01    [W:0.070 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site