lkml.org 
[lkml]   [2014]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 13/59] mtip32xx: Remove dfs_parent after pci unregister
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Asai Thambi S P <asamymuthupa@micron.com>

    commit af5ded8ccf21627f9614afc03b356712666ed225 upstream.

    In module exit, dfs_parent and it's subtree were removed before
    unregistering with pci. When debugfs entry for each device is attempted
    to remove in pci_remove() context, they don't exist, as dfs_parent and
    its children were already ripped apart.

    Modified to first unregister with pci and then remove dfs_parent.

    Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
    Signed-off-by: Jens Axboe <axboe@fb.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/block/mtip32xx/mtip32xx.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/block/mtip32xx/mtip32xx.c
    +++ b/drivers/block/mtip32xx/mtip32xx.c
    @@ -4990,13 +4990,13 @@ static int __init mtip_init(void)
    */
    static void __exit mtip_exit(void)
    {
    - debugfs_remove_recursive(dfs_parent);
    -
    /* Release the allocated major block device number. */
    unregister_blkdev(mtip_major, MTIP_DRV_NAME);

    /* Unregister the PCI driver. */
    pci_unregister_driver(&mtip_pci_driver);
    +
    + debugfs_remove_recursive(dfs_parent);
    }

    MODULE_AUTHOR("Micron Technology, Inc");



    \
     
     \ /
      Last update: 2014-07-05 01:41    [W:3.481 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site