[lkml]   [2014]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/3] clocksource: add device-tree support for PXA timer
Daniel Lezcano <> writes:

>> Good question.
>> Maybe not, I followed the same rationale as in orion-timer, which is :
>> - as this timer is the only possible timer for PXA boards, and because without
>> it the kernel boot will stall (scheduling will be blocked), it's better to
>> panic early that to remain stalled.
> There isn't the arm global timer ?
Nope, it's for Cortex-A9 AFAIK, and my poor platform is an old ARMv5 SoC.

>> Isn't this a good approach ?
> I suppose we can live with that. IMO, the right fix would be in clksrc-of to
> pr_crit a message when an initialization fails. But that means to change all the
> init functions for all drivers which is out of the scope of this patchset.
OK, you convinced me. I'll trade the panic() for a pr_crit(). Good idea, maybe
it will trigger a quest of a white knight for the other drivers :)



 \ /
  Last update: 2014-07-04 22:01    [W:0.059 / U:1.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site