lkml.org 
[lkml]   [2014]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch]blk-mq: suppress a warning
On 07/04/2014 05:26 AM, Shaohua Li wrote:
>
> The warning is hit when cpu hotplug is running. After scheduler puts a cpu
> online and before blk-mq mapping reinit, a task can queue a request and run the
> queue. At that time the cpu isn't in hctx->cpumask, but the cpu is mapped into
> hctx 0. When the race happens, hctx->cpumask doesn't set the cpu and
> ctx->index_hw/hctx->nr_ctx isn't correct, but it doesn't cause any problem. So
> just suppress the warning here.

Thanks Shaohua, I think that is an improvement. Not super fond of having
to do an extra map, but it's saner than the CPU test in that it uses the
same mechanism to verify it's correct. And we can probably kill this
WARN_ON() in a revision or two.




\
 
 \ /
  Last update: 2014-07-04 18:21    [W:0.065 / U:1.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site