Messages in this thread | | | Date | Wed, 30 Jul 2014 22:05:16 -0400 | Subject | Re: [PATCH] Remove certain calls for releasing page cache | From | Nick Krause <> |
| |
On Wed, Jul 30, 2014 at 7:30 PM, Dave Airlie <airlied@gmail.com> wrote: >> This patch removes the lines for releasing the page cache in certain >> files as this may aid in perfomance with writes in the compression >> rountines of btrfs. Please note that this patch has not been tested >> on my own hardware due to no compression based btrfs volumes of my >> own. >> > > For all that is sacred, STOP. > > Go and do something else, you are wasting people's valuable time, > > Don't send any patches you haven't tested ever. If you aren't capable > of setting up a VM to run compressed btrfs volumes in, what makes you > think you can patch the code. > > This isn't how you learn to be a kernel developer by wasting other > kernel developers time, if you can't work out why releasing the page cache > is necessary then don't send the patch until you have spent the time > understanding what the page cache is. > > I know you'll just ignore this, and keep on trucking just like you ignored > the other messages from Stephen before. > > But if you want to work on the kernel, this isn't the way to do it, and > nobody will ever take a patch from you seriously if you continue in this > fashion. > > Dave. Dave , Seems I need to have tested this code first. Regards Nick
| |