lkml.org 
[lkml]   [2014]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] mm, oom: remove unnecessary exit_state check
On 07/29, David Rientjes wrote:
>
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -455,6 +455,7 @@ static void exit_mm(struct task_struct * tsk)
> task_unlock(tsk);
> mm_update_next_owner(mm);
> mmput(mm);
> + clear_thread_flag(TIF_MEMDIE);
> }
>
> /*
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -258,8 +258,6 @@ enum oom_scan_t oom_scan_process_thread(struct task_struct *task,
> unsigned long totalpages, const nodemask_t *nodemask,
> bool force_kill)
> {
> - if (task->exit_state)
> - return OOM_SCAN_CONTINUE;

IIRC, this check was a workaround, to ensure that a oom-killed zombie
can't block oom-killer.

I think this patch can equally work.

Oleg.



\
 
 \ /
  Last update: 2014-07-30 18:41    [W:0.039 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site