lkml.org 
[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/18] lib: bitmap: Make nbits parameter of bitmap_full unsigned
    Date
    The compiler can generate slightly smaller and simpler code when it
    knows that "nbits" is non-negative. Since no-one passes a
    negative bit-count, this shouldn't affect the semantics.

    Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    ---
    include/linux/bitmap.h | 4 ++--
    lib/bitmap.c | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
    index 3d3fd6b..bc7e520 100644
    --- a/include/linux/bitmap.h
    +++ b/include/linux/bitmap.h
    @@ -89,7 +89,7 @@
    */

    extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
    -extern int __bitmap_full(const unsigned long *bitmap, int bits);
    +extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
    extern int __bitmap_equal(const unsigned long *bitmap1,
    const unsigned long *bitmap2, int bits);
    extern void __bitmap_complement(unsigned long *dst, const unsigned long *src,
    @@ -265,7 +265,7 @@ static inline int bitmap_empty(const unsigned long *src, unsigned nbits)
    return __bitmap_empty(src, nbits);
    }

    -static inline int bitmap_full(const unsigned long *src, int nbits)
    +static inline int bitmap_full(const unsigned long *src, unsigned int nbits)
    {
    if (small_const_nbits(nbits))
    return ! (~(*src) & BITMAP_LAST_WORD_MASK(nbits));
    diff --git a/lib/bitmap.c b/lib/bitmap.c
    index 3789110..9859f38 100644
    --- a/lib/bitmap.c
    +++ b/lib/bitmap.c
    @@ -55,9 +55,9 @@ int __bitmap_empty(const unsigned long *bitmap, unsigned int bits)
    }
    EXPORT_SYMBOL(__bitmap_empty);

    -int __bitmap_full(const unsigned long *bitmap, int bits)
    +int __bitmap_full(const unsigned long *bitmap, unsigned int bits)
    {
    - int k, lim = bits/BITS_PER_LONG;
    + unsigned int k, lim = bits/BITS_PER_LONG;
    for (k = 0; k < lim; ++k)
    if (~bitmap[k])
    return 0;
    --
    1.9.2


    \
     
     \ /
      Last update: 2014-07-04 09:21    [W:4.408 / U:0.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site