Messages in this thread | | | Date | Thu, 3 Jul 2014 18:08:11 -0400 | Subject | Re: [PATCH] microblaze: fixes includes in sigcontext.h | From | Nick Krause <> |
| |
You may be right I don't have a compiler that supports microblaze therefore I would suggest removing this FIXME message. Cheers Nick
On Thu, Jul 3, 2014 at 5:57 PM, David Rientjes <rientjes@google.com> wrote: > On Thu, 3 Jul 2014, Nicholas Krause wrote: > >> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h >> index 55873c8..1180d9b 100644 >> --- a/arch/microblaze/include/uapi/asm/sigcontext.h >> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h >> @@ -9,8 +9,7 @@ >> #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H >> #define _ASM_MICROBLAZE_SIGCONTEXT_H >> >> -/* FIXME should be linux/ptrace.h */ >> -#include <asm/ptrace.h> >> +#include <linux/ptrace.h> >> >> struct sigcontext { >> struct pt_regs regs; > > Umm, does this even compile? How does sigcontext.h get the definition of > struct pt_regs? Seems like it would be better to just do a forward > declaration.
| |